[fix](binlog) Report missing row binlog for INCR queries#65481
Merged
Conversation
TsukiokaKogane
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TsukiokaKogane
force-pushed
the
fix_incr_error_message
branch
from
fdd5d3a to
0d0d948
Compare
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29729 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-DS: Total hot run time: 180355 ms |
Contributor
ClickBench: Total hot run time: 25.07 s |
Contributor
Author
|
run fe_ut |
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29642 ms |
Contributor
TPC-DS: Total hot run time: 179813 ms |
Contributor
ClickBench: Total hot run time: 25.03 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
morrySnow
approved these changes
Jul 13, 2026
Contributor
|
/review |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review result: no blocking or inline issues found.
I reviewed the @incr binding change, the added FE unit test, and the regression test. The new validation order fails cleanly before RowBinlogTableWrapper can dereference missing row-binlog metadata, while valid row-binlog scans still use the wrapper before output binding and downstream scan-node translation. Non-@incr OLAP scan params still flow to validateOlapTable(), so branch/tag/snapshot/reset are not newly accepted on ordinary OLAP tables.
Critical checkpoint conclusions:
- Goal/test proof: the PR addresses missing row-binlog
@increrrors and adds both FE analyzer and regression negative coverage. - Scope/focus: the implementation is small and localized to
BindRelationplus targeted tests. - Concurrency/lifecycle/config/persistence/protocol: no new concurrency, lifecycle, config, persistence, or FE-BE protocol surface was introduced.
- Parallel paths: table-stream scan params remain on the separate stream path; valid row-binlog and direct-index
@incrpaths were checked. - Test coverage: the new tests cover the intended no-row-binlog failure; I did not run tests locally because this runner is review-only.
- User focus: no additional user-provided focus points were supplied.
Subagent convergence: round 1 normal implementation review, tests/coverage review, and risk-focused wrapper-validation review all returned NO_NEW_VALUABLE_FINDINGS; all main risk items were dismissed with code evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #65309
Related PR: #xxx
Problem Summary:
INCR analysis constructed the row-binlog table wrapper before validating that ROW binlog was enabled. Tables without ROW binlog therefore hit an unmessaged precondition in getRowBinlogMeta(), returning an empty detailMessage. Validate INCR conditions before wrapper construction so clients receive the actionable analysis error.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)